Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bootloader updater #397

Merged
merged 12 commits into from
Nov 21, 2022
Merged

Feat/bootloader updater #397

merged 12 commits into from
Nov 21, 2022

Conversation

BiliouriV
Copy link
Contributor

@BiliouriV BiliouriV commented Nov 4, 2022

By submiting this PR, you agree with the associated license (Apache 2.0 or MIT) and with our Contributor License Agreement (CLA).

Before to begin

Thank you for contributing to the Luos project!

Before to begin, please follow these steps:

  • Add the PR to the Luos contribution project

Feel free to read the Luos contribution's guidelines and the documentation page to have more insight about how to contribute to Luos.

PR Description section

Updater application for the bootloader

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@BiliouriV BiliouriV force-pushed the feat/bootloader_updater branch 2 times, most recently from 644e5ff to ce43deb Compare November 7, 2022 17:18
@BiliouriV BiliouriV marked this pull request as ready for review November 9, 2022 11:00
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Ok to me.

@JeromeGalan JeromeGalan force-pushed the feat/bootloader_updater branch from c787210 to a65111d Compare November 10, 2022 15:50
@JeromeGalan JeromeGalan merged commit bc75cb5 into rc_2.8.0 Nov 21, 2022
@JeromeGalan JeromeGalan deleted the feat/bootloader_updater branch November 21, 2022 13:51
JeromeGalan pushed a commit that referenced this pull request Nov 21, 2022
@JeromeGalan JeromeGalan linked an issue Dec 15, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] BOOTLOADER app to update Bootloader
4 participants